House not cooling and HVAC man comes out this AM and looks at unit then goes into attic. Invoice says compressor not pumping and metering device is fixed. Home warranty company sends out 2nd man for verification and he confirms first diagnosis except he explains everything. He shows me on the guages that both sides are rising instead of one dropping and one rising. It seems to the compressor is pumping if there is a pressure change. Right?

Hard to tell, sounds more like just a restriction in you line or metering device. But a compressor can run, but not pump as much as it is supposed to. This will give you high readings.

Tech said suction valves are bad...

Suction valve I assume means suction line king valve. That can be replaced.

Or does he mean compressor valves?

Sounds like the first tech got it right. Your compressor can run and not pump refrigerant(bad valves) and for his notes it was a piston type metering and not a expansion valve.