[jgelhorn]

I have an old light fixture with an outlet I went to replace and now need to put the old one back up and no matter what I do I have either constant light or no light no matter of the switch

[hkstroud]

Well you did something wrong.

Most likely you have switch loop and you connected the hot (black) from the light fixture to the power in hot (black) instead the switched hot from the switch (also black).

Describe the wire in the ceiling box.

[jgelhorn]

There are four wires two for the outlet attached to the fixture and two for the fixture itself two black two white and I have connected almost every wire to every wire

[hkstroud]

two for the outlet attached to the fixture

Could you explain that.

If you mean that there is one cable (with one black and one white wire) coming from the outlet, that is the cable bring power to the ceiling fixture from the outlet. The other cable (one black and one white wire) will be going to the switch.

Connect the black from the light fixture to the black of one cable. Connect the white from the fixture to the white in the same cable. Put a wire nut on the black wire in the other cable and a wire nut on the white wire. Turn the power back on. If the light burns you are connected to the power in cable. If the light does not burn you are connected to the switch.

Now put a piece of black on the white wire to the switch. This is so the next time you, or any body else, will know which cable goes to the switch.

Now connect the white from the light fixture to the white in the power cable. Connect the white with the black tape (in the switch cable) to the black in the power cable. Connect the black from the light fixture to the other black (in the cable to the switch).

[jgelhorn]

Sorry I have an older light fixture in my bathroom that is above the vanity that has an outlet on it so for each one there is a black wire and a white wire