In rreference to my question about my landlord stealing my money and engagement ring I was advised by a lawyer to send a demand letter to my exlandlord first. Do you think that is a good idea?

There's no harm in doing it, they will either respond with an offer to settle it without admitting they did anything or just ignore it in which case you can still sue