Hello, I am renovating a top floor bathroom and noticed there is no p trap under the shower, however I did notice one on the drain pipe in the basement. Is this acceptable?

Depending on the age of the house, it may not have a "P" trap. It may have a drum trap or an "S" trap, neither of which are code approved today. I do not believe that a house would have passed an inspection with the only trap being in the basement. UPC and IPC specify distance to a trap and I believe it is 24" measured vertical and horizontal.

Today, every shower should have trap directly under the shower drain. Since you are renovating, it is time to do it now. You will sleep better

Milo

You definitely need to install that trap directly under the shower... straight pipe out of the shower receptor into the PTRAP. You also want to check to be sure the shower drain is properly vented with either an individual vent pipe, or it could be wet vented by another fixture. Check local code requirements, of course, but for sure, there is more to this than just placing a trap. You also want to check to be sure that the drain line associated with the trap in the basement is NOT associated with the shower drain... if it is it will need to be removed!

Questions... let us know, OK?

Mark

Agree, add the trap but most important as Mark points out is to check to see it is vented properly

Thanks for the info! Mario

Will install ptrap under shower, it does go into a vent pipe and also I pretty sure the ptrap in the basement is associated with this shower. So will remove. But if I left it in place , wouldn't it just be a double insurance for sewer gases?Thanks all for your input... marjan6626