I always wake up and brush my teeth but the yellow stains on my teeth never vanish. Is there something that I am doing wrong or do I need to change my tooth brush or paste?

Well not brushing your teeth 3 times a day, could be the start.

Then do you smoke, drink coffee, lots of coke ? Sometimes changing your habits, esp smoking.

Also, when last time you had your teeth professionally cleaned?