"My urine is bright yellow and has been for 6months and there is an occasional odor. Should I be worried?

You could be getting a lot of vitamin B and/or C. It can also be from meds. May help if you drink more water.

Color and smell in urine is a sign of excess wastes of some type being discharged from the body,

A full medical test should show what the issues are