RE: washing steel siding in prep for primer and paint. Is TSP or vinegar in water THE preferred?

I can't think of any reason why Vinegar would be used. It is a mild acid and would only be effective on Calcium and possibly salt deposits and bare metal.

You can add Chlorine Bleach to the TSP per package directions if there is mold.