I'm a green card holder and I was living and working in MA from January 2005 to August 2005. The rest of the year (4 months) I lived in NYC and worked in upstate NY.

Should I file as resident in MA and non-resident in NY ?

Thanks!

No, you should file as a part-year resident of MA and NY and NYC.