Rewired a lamp and did positive wire to brass and negative to silver but it now won't

Sounds like a bad switch to me.

... agreed...