The old window itself is 36 x 36 inches. The new window states rough opening
36 in x 36 in. Actual 35.5 in x 35.5 in
Will this new window fit in the existing space?

Definitely should go right in with room for shims

If you measured 36" at the outside of the casing, it will fit.