My 2006 H-D Road King FLHRI starts fine then after it is turned off it "clicks when you try to re-start. If you let it cool for 10-15 minutes it starts back up My battery was 7yrs old so I thought that would solve the problem, nope.

Check Battery, Ground and Starter Connections.
Monitor Battery, then Starter connections, while trying to crank.