When the 5 pot lights are on this switch has a high noise coming from it some time & the next time no.
Should I change it.

Yes, change it to a good quality switch, look for what is called Spec Grade.